Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dst: add hardRestart command #895

Closed
wants to merge 2 commits into from
Closed

dst: add hardRestart command #895

wants to merge 2 commits into from

Conversation

asubiotto
Copy link
Member

@asubiotto asubiotto commented Jun 5, 2024

This simulates a hard restart by calling the vfs_shutdown hook on the wasm
host module to error out all filesystem calls.

Note

This PR is currently blocked on the resolution of #916, a bug that was found with DST but requires a more fundamental rearchitecture of the WAL.

Bugs found:

@asubiotto
Copy link
Member Author

asubiotto commented Jun 5, 2024

I'm not very happy with this PR since it's not a complete solution given open FDs. Will keep this up while I see how we can simulate wasi syscalls. The PR has been updated to use hooks into a VFS to simulate a hard shutdown, which is a more complete solution.

@asubiotto asubiotto marked this pull request as draft June 7, 2024 12:03
This simulates a hard restart by calling the vfs_shutdown hook on the wasm
host module to error out all filesystem calls.
Otherwise, the same error is returned on the next call to Wait. The desired
behavior is to resume the test with a new error group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant